-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] add submodule for C bindings, library compilation with PackageCompiler #88
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
- Coverage 70.18% 64.22% -5.97%
==========================================
Files 17 18 +1
Lines 1164 1258 +94
==========================================
- Hits 817 808 -9
- Misses 347 450 +103 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
The CI for Julia 1.9 fails as documenting I couldn't think of a good way of error handling.
I also couldn't find a reasonable way to translate Julia exceptions to C++ exceptions without going through C-bottleneck |
We don't need to support 1.9 I guess, but I hope we can backport JuliaLang/julia#51587 to 1.10. |
Yeah, I would agree we can drop support for 1.9 now, but the LTS release (1.10) we should try to support |
Just report this crashes on OS X with [ Info: PackageCompiler: Executing /Users/graemes/.julia/dev/JetReconstruction/compile/precompile_execution.jl => /var/folders/kq/jgwv_wcj3ll2n6qwj06pp6jr0000gn/T/jl_packagecompiler_0hx01x/jl_dsyOUt
julia(84816,0x1f264cf40) malloc: *** error for object 0x134add910: pointer being freed was not allocated
julia(84816,0x1f264cf40) malloc: *** set a breakpoint in malloc_error_break to debug
[84816] signal 6: Abort trap: 6
in expression starting at /Users/graemes/.julia/dev/JetReconstruction/compile/precompile_execution.jl:33 I'm investigating! |
Thanks for checking. I think that was because the |
Yes, now it works - thanks for the quick fix @m-fila! |
Adding C bindings and ahead of time compilation to shared library with PackageCompiler.jl
C components have
jetreconstruction_
(orJETRECONSTRUCTION_
) prefixFor now the C API includes only:
jet_reconstruct
exclusive_jets
,inclusive_jets
Vector{T}
field withPtr{T}
andCsize_t
fields for C-facing structs)The C header file has to be written manually and keep in sync with Julia code. Technically the whole
compile
could be a separate julia package possibly eveb living in a separate repo, but I think it'd be harder to keep in sync this wayTo do:
inclusive_jets
andexclusive_jets
JetReconstructionConfig.cmake
?juliac
?- [ ] add c-style building (make/CMake)?